Michal Skrivanek has posted comments on this change.
Change subject: virt: graphdev: add the GraphicsDevice class
......................................................................
Patch Set 27:
(2 comments)
http://gerrit.ovirt.org/#/c/26895/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4281: def setTicket(self, otp, seconds, connAct, params):
Line 4282: try:
Line 4283: graphics = _domParseStr(self._dom.XMLDesc(0)).childNodes[0]. \
Line 4284: getElementsByTagName('graphics')[0]
Line 4285: except IndexError:
Why do you add support for optional "display" in this
patch? I thought it i
I'd say regardless the "new feature", it's a
safenet which is good to have anyway.
(I'm good either way if it's here or next patch)
Line 4286: return {
Line 4287: 'status': {'code':
errCode['ticketErr']['status']['code'],
Line 4288: 'message': 'no graphics devices
configured'}}
Line 4289: graphics.setAttribute('passwd', otp)
Line 4309: try:
Line 4310: graphics = _domParseStr(
Line 4311: self._dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)). \
Line 4312: childNodes[0].getElementsByTagName('graphics')[0]
Line 4313: except IndexError:
Why is this needed? It seems that this function is called only if
self._vm.
again as a protection it makes sense to me
Line 4314: self.log.error('no graphics devices configured')
Line 4315: return
Line 4316: validto =
max(time.strptime(graphics.getAttribute('passwdValidTo'),
Line 4317: '%Y-%m-%dT%H:%M:%S'),
--
To view, visit
http://gerrit.ovirt.org/26895
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I82e4414aa3efe7c756ba8ef9b7b47e591613a717
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes