Juan Hernandez has posted comments on this change.
Change subject: Add "devcapacity" to PV info
......................................................................
Patch Set 2:
I agree that it is not the perfect solution. A better solution would be a
"getDeviceInfo" operation where we can provide as parameters the UUIDS of the
devices, otherwise we have to get the list of all devices (and those could be hundreds in
a large environment) just to extract the info of a few of them. But this is to a large
change for 3.0 and in addition it will make the API imcompatible with 2.X.
On the other hand I think that adding this "devcapacity" field is not a bad
thing, as it is an inherent property of a PV, already reported by tools like
"pvs".
Also note that RHEVM is not using internally the size to correlate things: it uses the LUN
UUID and the PV and VG UUIDs. What we want to do is to report to the end user the size of
the LUN (in addtition to the LUN UUID, which we already report) so that he/she, in his/her
mind, can do that correlation better.
--
To view, visit
http://gerrit.usersys.redhat.com/734
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0bd3c94a6e4999cb91f96c798a0108890321fbd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>