Federico Simoncelli has posted comments on this change.
Change subject: Group the cluster lock code into a new SP method
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 635: self._acquireTemporaryClusterLock(msdUUID, safeLease)
This is consistent with the rest of the APIs where we always pass the (m)sdUUID. I agree
that it's "expensive" but the creation and the master migration is done very
rarely. I agree on avoiding the "producing" calls but I don't see how that
is related to this specific patch. Please let's group this API design change in an
other patch that is taking care of changing them all.
--
To view, visit
http://gerrit.ovirt.org/603
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I981d84af7816ccd2db64eb5beb440e9f7637f734
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>