Federico Simoncelli has posted comments on this change.
Change subject: BZ#770834 - Handle correctly nic names like p33p1
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 133: nics_rexp = re.compile("^([A-Za-z]+)([0-9]+)$")
This is not correct because it's going to filter out interfaces like
"p33p1".
The original sed code is:
sed -e '/ifcfg-[A-Za-z0-9#\._-]\+$/ { s/^ifcfg-//g;s/[0-9]/ &/}'
This means that "p33p1" should be split as:
$ echo ifcfg-p33p1 \
| sed -e '/ifcfg-[A-Za-z0-9#\._-]\+$/ { s/^ifcfg-//g;s/[0-9]/ &/}'
p 33p1
The ordering then is the same:
sort -k 1,1 -k 2n
(It should be what we already have in the python code)
--
To view, visit
http://gerrit.ovirt.org/799
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>