Federico Simoncelli has posted comments on this change.
Change subject: vm: Avoid log spamming when drive format is undefined
......................................................................
Patch Set 2:
It's late so I won't -1 but it seems to me this is making the "format"
attribute optional. I definitely prefer to explicitly explode (forever) rather than keep
running without extensions and have no feedback whatsoever. If "format" got lost
we have to find it back (meaning that we have to understand in what flow it gets lost and
fix it).
--
To view, visit
http://gerrit.ovirt.org/22518
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia50e8af94b9c9b54332066a3f30999ce73e7a56f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-HasComments: No