Dan Kenigsberg has posted comments on this change.
Change subject: Related to 846307 - Simplifying clientIF._cleanOldFiles().
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File vdsm/clientIF.py
Line 453: return None
Line 454:
Line 455: def _cleanOldFiles(self):
Line 456: known_exts = ("guest.socket", "pid",
"recovery")
Line 457: dontDel = ("vdsmd.pid", "respawn.pid",
"svdsm.pid", "svdsm.sock")
I believe that "svdsm.sock" is superfluous here: it does not have one of the
known_exts.
P.S. why not set()s? (I know that the tuples are short)
Line 458:
Line 459: fNames = [fName for fName in os.listdir(constants.P_VDSM_RUN)
Line 460: if fName not in dontDel]
Line 461: for fName in fNames:
--
To view, visit
http://gerrit.ovirt.org/8626
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd63a1f4b1c64f84d5734da033a2420b97ce0ada
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>