Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
......................................................................
Patch Set 22:
(1 comment)
http://gerrit.ovirt.org/#/c/17694/22/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:
Line 29: self._devicesHash = str(hash(self._devices)) if self._devices else
'0'
Line 30:
Line 31: @staticmethod
Line 32: def fromId(uuid):
Line 33: return
DomainDescriptor('<domain><uuid>%s</uuid></domain>' %
uuid)
@Nir are you sure you're not confusing this with @classmethod?
https://docs I do not understand your question - Vinzenz is using a @staticmethod
and I suggested a @classmethod - where is the confusion?
Line 34:
Line 35: @property
Line 36: def xml(self):
Line 37: return self._xml
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes