Dan Kenigsberg has posted comments on this change.
Change subject: Added blkid tool support to get device for uuid.
......................................................................
Patch Set 9: Looks good to me, but someone else must approve
(1 inline comment)
Bala, I did minor changes for your patch since I suppose you are tired of it just as I am.
All I wanted is to avoid supervdsm for the clientIF call...
Never mind. Please ack if you're happy with the current patch.
....................................................
File vdsm/clientIF.py
Line 170: self.log.info('Error finding path for device',
exc_info=True)
calling str() is waiting for a unicode error to happen in the future.
--
To view, visit
http://gerrit.ovirt.org/2185
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>