Nir Soffer has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
......................................................................
Patch Set 25:
(2 comments)
Partial review
http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4489: return pid
Line 4490:
Line 4491: def _updateDomainDescriptor(self):
Line 4492: domainXML = self._dom.XMLDesc(0)
Line 4493: self._lastXMLDesc = DomainDescriptor(domainXML)
Lets clean up the ugly _lastXMLDesc - how about self._domain?
For example:
for device in self._domain.devices:
...
Or:
self._domain.xml
Line 4494:
Line 4495: def _ejectFloppy(self):
Line 4496: if 'volatileFloppy' in self.conf:
Line 4497: utils.rmFile(self.conf['floppy'])
Line 5045: def _getUnderlyingNetworkInterfaceInfo(self):
Line 5046: """
Line 5047: Obtain network interface info from libvirt.
Line 5048: """
Line 5049: # TODO use xpath instead of parseString (here and elsewhere)
This comment can be remove now.
Line 5050: for x in self._lastXMLDesc.getDeviceElements('interface'):
Line 5051: devType = x.getAttribute('type')
Line 5052: mac =
x.getElementsByTagName('mac')[0].getAttribute('address')
Line 5053: alias =
x.getElementsByTagName('alias')[0].getAttribute('name')
--
To view, visit
http://gerrit.ovirt.org/17694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev(a)gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes