Petr Horáček has posted comments on this change.
Change subject: net test: Replacing MonkeyPatch with mock.patch for netinfo_test
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/61269/2/tests/network/netinfo_test.py
File tests/network/netinfo_test.py:
PS2, Line 118: vdsm.network.netinfo.cache
Yes, but it is not a must and importing the whole module seemed
overdoing.
Is's ok, leave it as it is.
--
To view, visit
https://gerrit.ovirt.org/61269
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4e14162bb2773c50e551f4409c4c37cffe9f2a3
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes