Martin Polednik has posted comments on this change.
Change subject: yml: return type fixes for Host.hostdevListByCaps
......................................................................
Patch Set 2: Code-Review-1
(4 comments)
I have a feeling that some of the values are missing (correct me if I failed to understand
the schema). The ones I commented are *not* always returned and require hostdev / SR-IOV
capable host.
https://gerrit.ovirt.org/#/c/59703/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS2, Line 1392:
Missing?
PS2, Line 1410:
Um, where did this go?
PS2, Line 1416:
Missing?
PS2, Line 1385: HostDeviceAddress: &HostDeviceAddress
Can we model this as union? There are 3 possible types:
('domain', 'bus', 'slot', 'function') - PCI addr
('host', 'bus', 'target', 'lun') - SCSI addr
('bus', 'device') - USB addr
--
To view, visit
https://gerrit.ovirt.org/59703
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ad09c310a76dde9267824a337fadf3b1c02bd45
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes