Liron Aravot has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
......................................................................
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38623/4/vdsm/storage/volume.py
File vdsm/storage/volume.py:
Line 845: return meta
Line 846:
Line 847: def getLeaseState(self):
Line 848: ver, owners = sdCache.produce(self.sdUUID).inquireVolumeLease(
Line 849: self.imgUUID, self.volUUID)
why don't we want to return the owners if we already got that info? perhaps it could
be used by the engine
Line 850: return LEASE_HELD if owners else LEASE_FREE
Line 851:
Line 852: def getInfo(self):
Line 853: """
--
To view, visit
https://gerrit.ovirt.org/38623
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55f062a4be15593fdc98518fd0a113976cbe0ae7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes