Mark Wu has posted comments on this change.
Change subject: Define some constants in API.py
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/API.py
Line 610: INTERNAL = storage.volume.INTERNAL_VOL
Since currently the role "INTERNAL" is only used by the internal snapshot
management, I think we needn't export it in API. Does it make sense?
--
To view, visit
http://gerrit.ovirt.org/2262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>