Nir Soffer has posted comments on this change.
Change subject: hsm: prepareForShutdown - operations order
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36162/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 3432
Line 3433
Line 3434
Line 3435
Line 3436
I think that it will be more correct to move
self.taskMng.prepareForShutdown()
Before
sp.StoragePool.cleanupMasterMount()
Since you should not access shared storage after you release the locks.
But this will increase the chance that we do not reach the next line, and leave stale
locks around, because preparing taskMng for shutdown was too slow and vdsm was killed by
the service (after 10 seconds).
We need little more thinking.
--
To view, visit
http://gerrit.ovirt.org/36162
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9edd84317b08a17db80e265053edaf69582c2a51
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes