Dan Kenigsberg has posted comments on this change.
Change subject: configfile: remove no longer used methods. vdsm is no longer involved
in libvirt log rotation since 33925 and we can remove prefixLines and prependSection.
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
very partial review
https://gerrit.ovirt.org/#/c/36324/3/lib/vdsm/tool/configfile.py
File lib/vdsm/tool/configfile.py:
Line 127: continue
Line 128:
Line 129: if not self._remove or self._rmstate != WITHIN:
Line 130: if self._prefixRemove:
Line 131: # todo: remove once from 3.5 not supported
use our legacy-related comment
REQUIRE_FOR: upgrade from ovirt-3.5
Line 132: prefix = '# VDSM backup'
Line 133: if line.startswith(prefix):
Line 134: line = line[len(prefix):]
Line 135: m = confpat.match(line.rstrip())
--
To view, visit
https://gerrit.ovirt.org/36324
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf08bfebc83a9af5eb3c7de48f9a51d2263766fd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes