Yaniv Kaul has posted comments on this change.
Change subject: block: add blkdiscard on zero image
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/35631/3/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
Line 228:
Looking at blkdiscard's man:
-p, --step length
The number of bytes to discard within one iteration. The default
is to discard all by one ioctl call.
So for example, let's assume we have 1TB LV to discard - it cannot do it on one IOCTL.
What happens? Different storages have:
1. Different number of ranges they can unmap (most support 1 only, this is also what
VMware does and I believe Linux kernel's UNMAP. sg_unmap can do multiple ranges)
2. Maximum length of UNMAP (can be found via some VPD page).
--
To view, visit
https://gerrit.ovirt.org/35631
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e059c556c550440727b36b8af8e5dfc29ce2ccb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes