ShaoHe Feng has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File configure.ac
Line 67: [logrotate_compress=gzip],
Line 68: [logrotate_compress=xz]
Line 69: )
Line 70: ]
Line 71: )
agree.
if no xz was found, just fallback gzip without check it?
for the old code, does not check gzip.
Line 72: AC_MSG_NOTICE([configure logrotate compress by $logrotate_compress])
Line 73:
Line 74: if test "x$logrotate_compress" = xgzip; then
Line 75: AC_SUBST([COMPRESS_SUFFIX], [gz])
Line 74: if test "x$logrotate_compress" = xgzip; then
Line 75: AC_SUBST([COMPRESS_SUFFIX], [gz])
Line 76: AC_SUBST([REQUIRE_COMPRESS], [gzip])
Line 77: AC_PATH_PROG([COMPRESSCMD], [gzip], [/usr/bin/gzip])
Line 78: AC_PATH_PROG([UNCOMPRESSCMD], [gunzip], [/usr/bin/gunzip])
agree.
vdsm.spec.in, it require "xz" for logrotate.
there is no need to fallback on gazip for logrotate
Line 79: else
Line 80: AC_SUBST([COMPRESS_SUFFIX], [xz])
Line 81: AC_SUBST([REQUIRE_COMPRESS], [xz])
Line 82: AC_PATH_PROG([COMPRESSCMD], [xz], [/usr/bin/xz])
Line 82: AC_PATH_PROG([COMPRESSCMD], [xz], [/usr/bin/xz])
Line 83: AC_PATH_PROG([UNCOMPRESSCMD], [unxz], [/usr/bin/unxz])
Line 84: fi
Line 85: AC_CHECK_FILE(vdsm.spec, [rm -f vdsm.spec])
Line 86: AC_CHECK_FILE(vdsm/vdsm-logrotate.conf, [rm -f vdsm/vdsm-logrotate.conf])
try.
make clean or distclean can not remove these files.
also make can not update these files.
for the *.in was not touched, so the * will not be updated.
Line 87:
Line 88: # Checking for build tools
Line 89: AC_PROG_CC
Line 90: AC_PROG_LN_S
--
To view, visit
http://gerrit.ovirt.org/4174
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server