Douglas Schilling Landgraf has posted comments on this change.
Change subject: BZ#842948: deployUtil - safely remove bridge
......................................................................
Patch Set 7:
I don't think vdsm-store-net-config really works these days for oVirt Node. (I tested
as well instead of ovirt_safe_delete_config())
The code shows:
NET_CONF_DIR='/etc/sysconfig/network-scripts/'
NET_CONF_BACK_DIR=/var/lib/vdsm/netconfback
for f in "$NET_CONF_BACK_DIR"/*;
if [ -f "$NET_CONF_DIR/$bf" ];
then
ovirt_store_config "$NET_CONF_DIR/$bf"
else
ovirt_safe_delete_config "$NET_CONF_DIR/$bf"
However, using unpersist/rm or ovirt-functions to remove the bridge file this what
happens:
# unpersist ifcfg-breth0
# rm -f ifcfg-breth0
rm: cannot remove `ifcfg-breth0': Device or resource busy
# ls ifcfg-breth0
ifcfg-breth0
# . /usr/libexec/ovirt-functions
# ovirt_safe_delete_config ifcfg-breth0
# ls ifcfg-breth0
ifcfg-breth0
The file will only be removed from the filesystem in the next reboot.
In other words, the else statement will never be reached:
if [ -f "$NET_CONF_DIR/$bf" ];
then
ovirt_store_config "$NET_CONF_DIR/$bf"
else
ovirt_safe_delete_config "$NET_CONF_DIR/$bf"
Any suggestion? maybe Mike? Am I missing something?
--
To view, visit
http://gerrit.ovirt.org/6634
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e9b00ee4a38ebe7d5011e36bd9d3f7362cf26cd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Michael Burns <mburns(a)redhat.com>