Francesco Romani has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/36924/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1523: statsFlags = self._libvirtBackingChainStatsFlag()
Line 1524: conn = libvirtconnection.get()
Line 1525: blkStats = conn.domainListGetStats([self._dom._dom],
Line 1526: libvirt.VIR_DOMAIN_STATS_BLOCK,
Line 1527: statsFlags)[0][1]
I prefer to avoid the double indexing.
about the bulk stats, we
need a common shared API/pattern to use them. We're (hopefully) going to use them for
sampling as well and I want to avoid duplication
Line 1528: for i in xrange(0, blkStats['block.count']):
Line 1529: name = blkStats['block.%i.name' % i]
Line 1530: try:
Line 1531: drive = self._findDriveByName(name)
--
To view, visit
http://gerrit.ovirt.org/36924
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632f31e7795ec5d8c6f52a480116b14470c3163f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes