Eduardo has posted comments on this change.
Change subject: [WIP] Create storage domain using command type 1
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 1280: """
Line 1281: return os.path.exists(lvPath(vgName, lvName))
Line 1282:
Line 1283:
Line 1284: def changeVGTags(vgName, delTags=(), addTags=(), safe=True):
create is not the only valid case non-SPM doing this operation,
Please look at the comments in the last patch of this series.
changeVGtags() can be avoided in the destroySP().
In addition destroyStoragePool can remove the entire MD of the domain or remove it
enterily without changes to the subsequent formatStorageDomain(). The actual logic is
inconsistent.
In any case changeVGTags with locking type 1 without being SPM is not required.
Line 1285: delTags = set(delTags)
Line 1286: addTags = set(addTags)
Line 1287: if delTags.intersection(addTags):
Line 1288: raise se.VolumeGroupReplaceTagError(
--
To view, visit
http://gerrit.ovirt.org/23646
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes