Adam Litke has posted comments on this change.
Change subject: yml: parameter type fixes for StoragePool.connectStorageServer
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/59701/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS2, Line 381: Id
Can we do better? How about: A UUID that will be used to identify this connection in
subsequent API calls.
Line 380:
Line 381: - description: Id
Line 382: name: id
Line 383: type: *UUID
Line 384: type: object
Are you missing: ifaceName, initiatorName, and netIfaceName?
Line 385:
Line 386: LocalFsConnectionParameters: &LocalFsConnectionParameters
Line 387: added: '3.1'
Line 388: description: Parameters for initiating a connection to
Line 5555: 0: The type is not known
Line 5556: 1: The Storage Domain uses Network File System based storage
Line 5557: 2: The Storage Domain uses FibreChannel based storage
Line 5558: 3: The Storage Domain uses iSCSI based storage
Line 5559: 4: The Storage Domain uses storage on the local file system
5 is CIFS (aka smbfs). If it's deprecated we can say so here but I don't think it
should be omitted.
Line 5560: 6: The Storage Domain uses posix file system
Line 5561: 7: The Storage Domain uses glusterfs
Line 5562:
Line 5563: StorageDomainInfo: &StorageDomainInfo
--
To view, visit
https://gerrit.ovirt.org/59701
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9fe2ffc3bc2327eefaae794b7b366e8202d2f2a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes