Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Refactor storage connection subsystem
......................................................................
Patch Set 15: Fails
(6 inline comments)
pyflakes failures cause a build failure.
....................................................
File vdsm/storage/storageServer.py
Line 22: import logging
pyflakes:
vdsm/storage/storageServer.py:22: 'logging' imported but unused
Line 23: from os.path import normpath, basename, splitext
pyflakes:
vdsm/storage/storageServer.py:23: 'splitext' imported but unused
vdsm/storage/storageServer.py:23: 'basename' imported but unused
Line 25: from threading import RLock, Lock, Event, Thread
pyflakes:
vdsm/storage/storageServer.py:25: 'Thread' imported but unused
vdsm/storage/storageServer.py:25: 'RLock' imported but unused
vdsm/storage/storageServer.py:25: 'Lock' imported but unused
vdsm/storage/storageServer.py:25: 'Event' imported but unused
Line 27: import pickle
pyflakes:
vdsm/storage/storageServer.py:27: 'pickle' imported but unused
Line 28: import glob
pyflakes:
vdsm/storage/storageServer.py:28: 'glob' imported but unused
Line 34: from sync import asyncmethod, AsyncCallStub
pyflakes:
vdsm/storage/storageServer.py:34: 'asyncmethod' imported but unused
vdsm/storage/storageServer.py:34: 'AsyncCallStub' imported but unused
--
To view, visit
http://gerrit.ovirt.org/1038
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc5c160aba9b4cc88225dde0c44f9b766c6a4c0d
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: shu ming <sming56(a)gmail.com>