ShaoHe Feng has posted comments on this change.
Change subject: make compression type configurable, support gzip and xz
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File configure.ac
Line 42: AC_PATH_PROG([XZ], [xz])
yes, the logrotate compress type are same on build machine and the target machine by
default.
Actually, if distribution was compressed by gzip, and logrotate configure compress type xz
with the '--with-xz', the target machine should support both gzip and xz.tha is
not we want.
So I think the logrotate compress type and distribution compress type should be configured
same, and should be both configured by argument ike '--with-xz, --with-gzip'
--
To view, visit
http://gerrit.ovirt.org/4174
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d88e9d40aefc87564c9c7e23f0d28aaad867aca
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>