Adam Litke has posted comments on this change.
Change subject: Define some constants in API.py
......................................................................
Patch Set 4: (3 inline comments)
....................................................
File vdsm/API.py
Line 610: INTERNAL = storage.volume.INTERNAL_VOL
Fair enough. I will remove it. We can always introduce it again if needed.
Line 760: DEFAULT_VERSION = storage.sd.DOM_SAFELEASE_VERS[0]
It's exposed so that the xmlrpc bindings can set it as a default parameter in
domainCreate. API.py already handles version==None in this way so I guess we can remove
it.
Line 945: MAX_HOST_ID = storage.safelease.MAX_HOST_ID
It's a default parameter for poolSpmStart in the xmlrpc bindings. Also handled in
API.py so removable.
--
To view, visit
http://gerrit.ovirt.org/2262
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>