Nir Soffer has posted comments on this change.
Change subject: py3 tests: ported imagetickets_test.py to python3
......................................................................
Patch Set 2:
(1 comment)
Looks good, actually too good to be true. I believe the actual code will fail in python 3
:-)
https://gerrit.ovirt.org/#/c/59859/2/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 37
Line 38
Line 39
Line 40
Line 41
This works, but I think that in python3 response.read() returns bytes object, not string.
So this test works now in python3, but the real code will probably fail.
Can you test what is returned in python3 and fix the test to return same types?
--
To view, visit
https://gerrit.ovirt.org/59859
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes