Ayal Baron has posted comments on this change.
Change subject: MOM Integration
......................................................................
Patch Set 13: I would prefer that you didn't submit this
(5 inline comments)
Minor issues
....................................................
File vdsm/ksm.py
Line 114: raise Exception('Invalid KSM tuning parameter: %s=%s' % (k,
v))
you could also make sure that values are proper (run in [0,1,2] etc)
....................................................
File vdsm/libvirtvm.py
Line 2067: if self.cif.ksmMonitor:
for symmetry perhaps this should be if not self.mom
....................................................
File vdsm/vm.py
Line 572: and self.cif.ksmMonitor:
again, perhaps not self.mom
Line 574: # behaviors on VM start/destroy. Because the tuning can be
s/. B/, b/
Line 575: # done automatically acccording its statistics data.
s/its statistics/to its statistical/
--
To view, visit
http://gerrit.ovirt.org/2367
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I61e68f72e9115a913d5bc0f4903b906b0d0cce2f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Xu He Jie <xuhj(a)linux.vnet.ibm.com>