Greg Padgett has posted comments on this change.
Change subject: BZ#826921: Don't ignore nfs_mount_options in vdsm.conf
......................................................................
Patch Set 8: Verified
This patch sends an alert to the engine, as suggested by Dan.
Any ideas on how to make it cleaner are welcome--it felt like a bit of a hack putting the
code to propagate status from the NFS connection to the storage pools right in the middle
of the HSM class. However, I didn't see any other place with the ability to do this.
Also, I'm not sure if there are thread safety issues here as I don't know the
architecture quite well enough to know what needs to be synchronized versus what already
is.
Also see engine patch for alert text at
http://gerrit.ovirt.org/7658
--
To view, visit
http://gerrit.ovirt.org/5368
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c1d13bfd98a9b41b9728bdcb7f01b3161c26bd8
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server