Nir Soffer has posted comments on this change.
Change subject: udevadm: More precise error handling
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39740/1//COMMIT_MSG
Commit Message:
Line 15: caller is responsible to handle the error.
Line 16:
Line 17: In both multipath.rescan() and IscsiConnection.connect(), we warn about
Line 18: timeout but do not handle other errors, so real errors in udevadm will
Line 19: fail loudly.
Failing loudly when udevadm settle fails is not very useful, maybe we should
instead log the error and wait couple of seconds.
So I think we should handle all errors inside settle like this:
deadline = monotonic_time + timeout
try:
_run_until(cmd, deadline)
except Timeout:
log warning
except Failure:
log error
time.sleep(deadline - monotonic_time())
Line 20:
Line 21: Change-Id: Ia0a7380b1b181ec93399ea741122cfa2e98086fb
Line 22: Relates-To:
https://bugzilla.redhat.com/1209474
--
To view, visit
https://gerrit.ovirt.org/39740
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0a7380b1b181ec93399ea741122cfa2e98086fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes