Vinzenz Feenstra has posted comments on this change.
Change subject: vdsm: storage replace/remove too generic except handlers
......................................................................
Patch Set 2:
(2 comments)
....................................................
File vdsm/storage/dispatcher.py
Line 40: self.help = None
Line 41: try:
Line 42: if hasattr(func.im_self, "help"):
Line 43: self.help = getattr(func.im_self, "help")
Line 44: except AttributeError:
well if func has no attribute im_self...
Line 45: pass
Line 46:
Line 47: if not self.help:
Line 48: try:
....................................................
File vdsm/storage/hsm.py
Line 3481: exc_info=True)
Line 3482: continue
Line 3483:
Line 3484: self.taskMng.prepareForShutdown()
Line 3485: except Exception:
ok
Line 3486: pass
Line 3487:
Line 3488: @classmethod
Line 3489: def __releaseLocks(cls):
--
To view, visit
http://gerrit.ovirt.org/17751
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09dcada40bca3f16f94ad7a6c83e6d7a85ade77
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes