Change in vdsm[master]: net: Post bond ifup, wait until its link comes up
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Post bond ifup, wait until its link comes up
......................................................................
net: Post bond ifup, wait until its link comes up
When acquiring the device from NM, it may take a few seconds until
the bond is released by NM and loaded through initscripts.
This patch is giving the bond a chance to come up before continuing.
The problem appeared in one of the NM functional tests:
test_add_net_based_on_device_with_multiple_nm_connections
Change-Id: I9308a87f32ef5fb32bfea06c95721d8cacd67c56
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/77090
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9308a87f32ef5fb32bfea06c95721d8cacd67c56
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: net: Wait for link-up when creating a bond through link.bond
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Wait for link-up when creating a bond through link.bond
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77092
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d8e1fe47881ff4e133524fca4a070d481e84e15
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net: Post bond ifup, wait until its link comes up
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Post bond ifup, wait until its link comes up
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77090
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9308a87f32ef5fb32bfea06c95721d8cacd67c56
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net test: Use a single slave in the NM vlan-bond-slave sync ...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Use a single slave in the NM vlan-bond-slave sync test
......................................................................
Patch Set 5: Code-Review+2
Evil trick!
--
To view, visit https://gerrit.ovirt.org/77089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65ef31973198914e22d0d8da08b6a81e386ca533
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: net test: Refactor NM tests and its test lib
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Refactor NM tests and its test lib
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6dd262c40607088613ab9be4f1911e11f1926e47
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 11 months
Change in vdsm[master]: vm: support creating vhostuser interface
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: support creating vhostuser interface
......................................................................
Patch Set 22: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/74327/22/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
Line 159: CA_FILE = os.path.join(PKI_DIR, 'certs', 'cacert.pem')
Line 160:
Line 161: # vhost user sockets path
Line 162:
Line 163: VHOST_SOCK_DIR = os.path.join(P_VDSM_RUN, 'vhostuser')
other directories sit in the top of this file, and have P_ as a prefix.
But more importantly, would you remind me why do we want to add it to the constants.py junkyard? It is currently used only in lib/vdsm/virt/vmdevices/network.py so maybe it should be defined only there?
--
To view, visit https://gerrit.ovirt.org/74327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 11 months
Change in vdsm[master]: network api: update ovs_bridge call
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network api: update ovs_bridge call
......................................................................
network api: update ovs_bridge call
ovs_bridge now returns bridge name and a boolean indicating
if it contains a dpdk type port.
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
Change-Id: I02c98e4098d61b54300d144dc29b519ef3f431ad
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netswitch/configurator.py
M lib/vdsm/network/ovs/info.py
M lib/vdsm/virt/vmdevices/network.py
M tests/device_test.py
M tests/network/ovs_info_test.py
M tests/virttests/devicexml_test.py
7 files changed, 23 insertions(+), 9 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/74512
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02c98e4098d61b54300d144dc29b519ef3f431ad
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[master]: ovs driver: introduce add_vhostuser_iface command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs driver: introduce add_vhostuser_iface command
......................................................................
ovs driver: introduce add_vhostuser_iface command
The command supports setting dpdkvhostuserclient inreface type.
Change-Id: Ie44fe082cffdaf3351450d55da7f48b2a9f7b315
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/network/ovs/driver/__init__.py
M lib/vdsm/network/ovs/driver/vsctl.py
2 files changed, 9 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75026
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie44fe082cffdaf3351450d55da7f48b2a9f7b315
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in vdsm[ovirt-4.1]: api: log call context for api calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: log call context for api calls
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/77173
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 12 months
Change in vdsm[ovirt-4.1]: common: move thread local
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: common: move thread local
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/77171
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If041a1ce38087d209258dc1a7661161f8f65c03c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 12 months