From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vm: support creating vhostuser interface
......................................................................
Patch Set 22: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/74327/22/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:
Line 159: CA_FILE = os.path.join(PKI_DIR, 'certs', 'cacert.pem')
Line 160:
Line 161: # vhost user sockets path
Line 162:
Line 163: VHOST_SOCK_DIR = os.path.join(P_VDSM_RUN, 'vhostuser')
other directories sit in the top of this file, and have P_ as a prefix.
But more importantly, would you remind me why do we want to add it to the constants.py
junkyard? It is currently used only in lib/vdsm/virt/vmdevices/network.py so maybe it
should be defined only there?
--
To view, visit
https://gerrit.ovirt.org/74327
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes