Change in vdsm[master]: api: log call context for api calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: log call context for api calls
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/75517/9//COMMIT_MSG
Commit Message:
Line 20:
Line 21: and if the context is not available because the method was called
Line 22: internally we see:
Line 23:
Line 24: START getCapabilities() from=internal (api:41)
I don't see any reason to add labels
START [FUNC NAME] [optional SOURCE] [optional FLOW_ID]
FINISH [FUNC NAME] [optional SOURCE] [optional FLOW_ID]
I wouldn't include [Module:Line] and I would try to make it short and clean.
Line 25:
Line 26:
Line 27: Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
--
To view, visit https://gerrit.ovirt.org/75517
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I128a338037b22b43b1065cfb40ea95de6f371b99
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 1 month
Change in vdsm[master]: common: move thread local
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: common: move thread local
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75516
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If041a1ce38087d209258dc1a7661161f8f65c03c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: api: adding context for api calls
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: api: adding context for api calls
......................................................................
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75335
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e73edc929e6d3e55d3f33a51229180ba35c52ac
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[ovirt-4.1]: register: _execute_http_request: adhere to cert_validation
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: register: _execute_http_request: adhere to cert_validation
......................................................................
register: _execute_http_request: adhere to cert_validation
Before this patch, if self.check_fqdn is set, cert_validation=False was
ignored.
Change-Id: Id757fe243ea6f6344146e8e6c82b727947816bb8
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1447881
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M lib/vdsm/tool/register.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified
Yaniv Bronhaim: Looks good to me, approved
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74591
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id757fe243ea6f6344146e8e6c82b727947816bb8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[ovirt-4.1]: register: _execute_http_request: adhere to cert_validation
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: register: _execute_http_request: adhere to cert_validation
......................................................................
Patch Set 2: Code-Review+2
thanks for waiting for me! very appreciated, as I literally forked this code in ovirt-containers. I'll patch it there as well.
--
To view, visit https://gerrit.ovirt.org/74591
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id757fe243ea6f6344146e8e6c82b727947816bb8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 1 month
Change in vdsm[master]: hoststats: report hugepages
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hoststats: report hugepages
......................................................................
hoststats: report hugepages
We have previously added hugepage sizes to the capabilities, now what
we want to do is report the actual hugepages usage. To do that, we
extend HostSample and monitoring to provide the data via the hugepages
module.
How that looks on a host with 2KiB and 1GiB hugepages enabled:
"hugepages": {
1048576: {
"resv_hugepages": "0",
"free_hugepages": "0",
"nr_overcommit_hugepages": "0",
"surplus_hugepages": "0",
"nr_hugepages": "0",
"nr_hugepages_mempolicy": "0"
},
2048: {
"resv_hugepages": "0",
"free_hugepages": "10",
"nr_overcommit_hugepages": "0",
"surplus_hugepages": "0",
"nr_hugepages": "10",
"nr_hugepages_mempolicy": "10"
}
}
Change-Id: I9b85484d97844b7fdb719bd893404e6641a4b5e5
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/host/stats.py
M lib/vdsm/virt/sampling.py
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/75079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b85484d97844b7fdb719bd893404e6641a4b5e5
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: sampling: fix typos
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: fix typos
......................................................................
sampling: fix typos
Change-Id: Ic25160848532e4e8158cbea1721fd317a03ea509
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/virt/sampling.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adam Litke: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Francesco Romani: Verified; Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/75078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic25160848532e4e8158cbea1721fd317a03ea509
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: hugepages: reporting
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hugepages: reporting
......................................................................
hugepages: reporting
Hugepages can be accessed via sysfs interface
/sys/kernel/mm/hugepages
which contains subdirectories indicating various hugepage sizes
present on the system e.g.
$ ls /sys/kernel/mm/hugepages
hugepages-1048576kB hugepages-4096kB
and each hugepage size contains files with a piece of information
indicated by the filename:
free_hugepages nr_hugepages nr_hugepages_mempolicy
nr_overcommit_hugepages resv_hugepages surplus_hugepages
VDSM can report availablity of hugepages caps key:
caps = {...
hugepages = [4096, 1048576],
...}
Change-Id: Iefd97d067bde140c2f62597d3ce3bd537487d60d
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/Makefile.am
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/host/caps.py
A lib/vdsm/hugepages.py
M tests/Makefile.am
A tests/hugepages_test.py
M vdsm.spec.in
7 files changed, 177 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/66397
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefd97d067bde140c2f62597d3ce3bd537487d60d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: hugepages: add function to (de)alloc hugepages
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hugepages: add function to (de)alloc hugepages
......................................................................
hugepages: add function to (de)alloc hugepages
Small (currently unused) function that is able to allocate or
deallocate (given negative number of allocations) a default-sized
hugepages (of size default for given platform).
Change-Id: I0983317337466f11d832475169e810acc4d75b2d
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/hugepages.py
M lib/vdsm/supervdsm_api/virt.py
M tests/Makefile.am
M tests/hugepages_test.py
4 files changed, 130 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/75230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0983317337466f11d832475169e810acc4d75b2d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month
Change in vdsm[master]: virt net: Access libvirt networking module directly
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt net: Access libvirt networking module directly
......................................................................
virt net: Access libvirt networking module directly
libvirt networking module is being accessed from virt through the
networking api.
In order to assist in relocating the libvirt networking module from
network to virt (in a following patch), this patch drops libvirt
networking related calls from the network api, requiring the callers to
call it directly.
Change-Id: Iabdde2f2053218e28f52c01d3cd56671d44437fe
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/libvirt.py
M lib/vdsm/virt/vmdevices/graphics.py
M lib/vdsm/virt/vmdevices/network.py
M tests/device_test.py
M vdsm/virt/vm_migrate_hook.py
6 files changed, 22 insertions(+), 32 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76161
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabdde2f2053218e28f52c01d3cd56671d44437fe
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 1 month