Change in vdsm[master]: dpdk: update lshw command
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dpdk: update lshw command
......................................................................
dpdk: update lshw command
lshw command lists all hardware devices. polling USB, IDE and SCSI
is not required as we're only interested in network devices.
Disabling these calls reduces the amount of time 'lshw' command runs.
Change-Id: Id5b38a2d2253bd7383235f46848731fe63c04f8b
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/network/link/dpdk.py
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76579
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5b38a2d2253bd7383235f46848731fe63c04f8b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: hostdev: update_device_info: handle unknown device type
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hostdev: update_device_info: handle unknown device type
......................................................................
hostdev: update_device_info: handle unknown device type
Preparation for mdev hook. We want to make sure not to touch libvirt
since mdevs aren't standard devices.
Change-Id: I23b3c7f4eccfd3968eba8e6dca59a5185ffca71b
Bug-Url: https://bugzilla.redhat.com/1444992
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/hostdevice.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/76611
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23b3c7f4eccfd3968eba8e6dca59a5185ffca71b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: hugepages: update the hook
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hugepages: update the hook
......................................................................
hugepages: update the hook
The hook can now use facilities provided by VDSM library for hugepage
manipulation. As a side effect, we have now fixed the hook for ppc64le
platform.
Change-Id: I177c771afa798dda8fa1b51c7909e393ac305945
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M vdsm_hooks/hugepages/after_vm_destroy.py
M vdsm_hooks/hugepages/before_vm_migrate_destination.py
M vdsm_hooks/hugepages/before_vm_start.py
3 files changed, 9 insertions(+), 93 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/75231
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I177c771afa798dda8fa1b51c7909e393ac305945
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Implement vdsm-store-net-config in netconfpersistence
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Implement vdsm-store-net-config in netconfpersistence
......................................................................
net: Implement vdsm-store-net-config in netconfpersistence
Drop vdsm-store-net-config shell script and implement its functionality
into netconfpersistence.
Change-Id: I46786d2720b80723b390781f440ab409c02b05b7
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M .gitignore
M lib/vdsm/constants.py.in
M lib/vdsm/network/netconfpersistence.py
M vdsm.spec.in
M vdsm/Makefile.am
D vdsm/vdsm-store-net-config.in
6 files changed, 25 insertions(+), 38 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I46786d2720b80723b390781f440ab409c02b05b7
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net, virt net: Relocate network.libvirt to virt.libvirtnetwork
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net, virt net: Relocate network.libvirt to virt.libvirtnetwork
......................................................................
net, virt net: Relocate network.libvirt to virt.libvirtnetwork
Access to libvirt networks is now limited to virt (with a small
exception for the configuration upgrade, see netupgrade).
Therefore, the module is moved from the network package to the virt
package.
Change-Id: I6d910f8313f7fb6abcc966e7e0419a720809bdb7
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/Makefile.am
M lib/vdsm/network/netupgrade.py
M lib/vdsm/virt/Makefile.am
R lib/vdsm/virt/libvirtnetwork.py
M lib/vdsm/virt/vmdevices/graphics.py
M lib/vdsm/virt/vmdevices/network.py
M tests/network/netupgrade_test.py
R tests/virttests/libvirtnetwork_test.py
M vdsm.spec.in
M vdsm/virt/vm_migrate_hook.py
10 files changed, 36 insertions(+), 35 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, but someone else must approve
Francesco Romani: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76164
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6d910f8313f7fb6abcc966e7e0419a720809bdb7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Implement vdsm-store-net-config in netconfpersistence
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Implement vdsm-store-net-config in netconfpersistence
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I46786d2720b80723b390781f440ab409c02b05b7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Set ifcfg.ConfigWriter.clearBackups as staticmethod
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Set ifcfg.ConfigWriter.clearBackups as staticmethod
......................................................................
net: Set ifcfg.ConfigWriter.clearBackups as staticmethod
There is no reason to leave clearBackups as a classmethod and converting
it to a staticmethod will allow its usage by external modules.
This modification is part of the attempt to convert the
vdsm-store-net-config shell script into python.
Change-Id: Iffba252448fd5eae91dcf437c40e017cf48e0c9f
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76326
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffba252448fd5eae91dcf437c40e017cf48e0c9f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Use python to clear backups instead of the shell
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use python to clear backups instead of the shell
......................................................................
net: Use python to clear backups instead of the shell
When storing the network config as "safe", vdsm-store-net-config has
been used to clear the ifcfg backups.
This patch uses the python version to clear the ifcfg backups instead of
the shell, adding another step towards the removal of the
vdsm-store-net-config shell script.
Change-Id: Ia3673a176ec4f2ebb1076bda8727992b8f38a52c
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/api.py
M lib/vdsm/network/netupgrade.py
M vdsm/vdsm-store-net-config.in
3 files changed, 4 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/76327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3673a176ec4f2ebb1076bda8727992b8f38a52c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: net: Use python to clear backups instead of the shell
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use python to clear backups instead of the shell
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76327
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3673a176ec4f2ebb1076bda8727992b8f38a52c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: net: Set ifcfg.ConfigWriter.clearBackups as staticmethod
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Set ifcfg.ConfigWriter.clearBackups as staticmethod
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76326
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffba252448fd5eae91dcf437c40e017cf48e0c9f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years