Change in vdsm[master]: ssl: client cert check for IPv4 mapped addresses
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: client cert check for IPv4 mapped addresses
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/76197/4/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:
Line 239:
Line 240: return False
Line 241:
Line 242: @staticmethod
Line 243: def compare_names(src_addr, cert_common_name):
can you add a CompareNameTest so what is added here is clearer and does not break?
Line 244: ip = IPAddress(src_addr)
Line 245: if ip.is_ipv4_mapped():
Line 246: src_addr = str(ip.ipv4())
Line 247:
--
To view, visit https://gerrit.ovirt.org/76197
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic012664db7181ab703ec4de53a0ba7c225bb73f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: pylint: vm: simplify the exception flow
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: vm: simplify the exception flow
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/76185
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib35036f35be4df6462676018eb4d0b69fc69bf65
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: pylint: v2v: silence pylint complains
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: v2v: silence pylint complains
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76186
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54c58549ad2dbd85bbf7e1d0663dfefefde02ab1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: pylint: fix and silence pylint errors in vm.py
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: fix and silence pylint errors in vm.py
......................................................................
pylint: fix and silence pylint errors in vm.py
Silences:
E:2259,31: Instance of 'Interface' has no 'portMirroring' member (no-member)
E:2260,67: Instance of 'Interface' has no 'name' member (no-member)
Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in vdsm[master]: pylint: fix and silence pylint errors in vm.py
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: fix and silence pylint errors in vm.py
......................................................................
Patch Set 8: Code-Review+2 Verified+1
no code change
--
To view, visit https://gerrit.ovirt.org/75749
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I95cd8a090cceaa433a683a119653df0653e974e5
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: pylint: virt: fix missing attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: pylint: virt: fix missing attribute
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/76184
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad67878fd053e28205384fa3e7e8375651348c66
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years
Change in vdsm[master]: pylint: v2v: silence error
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: pylint: v2v: silence error
......................................................................
pylint: v2v: silence error
Due to https://github.com/PyCQA/pylint/issues/961
pylint does not recognize uuid.UUID.int
Change-Id: I94c8d6d3a38bc3d2fc9fa408d07649eb78afca3f
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/virt/containers/domain.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/76/76176/1
diff --git a/lib/vdsm/virt/containers/domain.py b/lib/vdsm/virt/containers/domain.py
index 6eb284c..531a727 100644
--- a/lib/vdsm/virt/containers/domain.py
+++ b/lib/vdsm/virt/containers/domain.py
@@ -96,6 +96,8 @@
return str(self._rt.uuid)
def ID(self):
+ # pylint: disable=no-member
+ # due to https://github.com/PyCQA/pylint/issues/961
return self._vm_uuid.int
def UUIDString(self):
--
To view, visit https://gerrit.ovirt.org/76176
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94c8d6d3a38bc3d2fc9fa408d07649eb78afca3f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
7 years
Change in vdsm[master]: net: Embed vdsm-restore-net-config into vdsm.network
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Embed vdsm-restore-net-config into vdsm.network
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/76085/2/lib/vdsm/supervdsm_api/network.py
File lib/vdsm/supervdsm_api/network.py:
Line 23: from vdsm.sysctl import set_rp_filter_loose, set_rp_filter_strict
Line 24: from vdsm.network.api import (setSafeNetworkConfig, setupNetworks,
Line 25: change_numvfs, network_caps, ovs_bridge,
Line 26: add_sourceroute, remove_sourceroute)
Line 27: from vdsm.network.restore_net_config import restore
> Because this restore is using the API to restore networks (setupNetworks).
sorry, I do not follow.
Line 28: from vdsm.network.tc import setPortMirroring, unsetPortMirroring
Line 29:
Line 30:
Line 31: @expose
--
To view, visit https://gerrit.ovirt.org/76085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c3d0ca93179aeb98a89f68265e368d13924f21e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years
Change in vdsm[master]: pylint: Remove broken and unneeded code
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Remove broken and unneeded code
......................................................................
pylint: Remove broken and unneeded code
oop.os.rename() was trying to handle the case when the destination
directory exists and is not empty. In this case, the code tried to
delete the destination directory, and rename the source directory.
This code was broken, failing with:
AttributeError: '_IOProcessOs' object has no attribute 'listdir'
The broken code was introduced in commit 576428e876c2 (ioprocess
implementation), and is available since 4.16.0.
The only effected flow is Image.delete, when we rename the image
directory to remove_me_<uuid>. In this flow, we do not expect that the
destination directory to exist.
This patch removes the unneeded functionality, restoring POSIX
semantics.
Change-Id: I352e8643a47f517c879d2085bced6847e0372b30
Bug-Url: https://bugzilla.redhat.com/1444659
Reported-by: pylint
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/storage/outOfProcess.py
1 file changed, 1 insertion(+), 14 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/75791
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I352e8643a47f517c879d2085bced6847e0372b30
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years