From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: pylint: Remove broken and unneeded code
......................................................................
pylint: Remove broken and unneeded code
oop.os.rename() was trying to handle the case when the destination
directory exists and is not empty. In this case, the code tried to
delete the destination directory, and rename the source directory.
This code was broken, failing with:
AttributeError: '_IOProcessOs' object has no attribute 'listdir'
The broken code was introduced in commit 576428e876c2 (ioprocess
implementation), and is available since 4.16.0.
The only effected flow is Image.delete, when we rename the image
directory to remove_me_<uuid>. In this flow, we do not expect that the
destination directory to exist.
This patch removes the unneeded functionality, restoring POSIX
semantics.
Change-Id: I352e8643a47f517c879d2085bced6847e0372b30
Bug-Url:
https://bugzilla.redhat.com/1444659
Reported-by: pylint
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/storage/outOfProcess.py
1 file changed, 1 insertion(+), 14 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/75791
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I352e8643a47f517c879d2085bced6847e0372b30
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>