Francesco Romani has uploaded a new change for review.
Change subject: daemon: enable cpu affinity by default
......................................................................
daemon: enable cpu affinity by default
To run VDSM with CPU affinity enabled provided only
(huge) benefits in the tests performed so far, so let's
enable it by default.
Change-Id: I9a00926926bb4075e17b69f633bf31b5389eefc1
Bug-Url: https://bugzilla.redhat.com/1279431
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/config.py.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/48296/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 203d292..6775ba8 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -211,10 +211,10 @@
('connection_stats_timeout', '3600',
'Time in seconds defining how frequently we log transport stats'),
- ('cpu_affinity', '',
+ ('cpu_affinity', '1',
'Comma separated whitelist of CPU cores on which VDSM is allowed '
- 'to run. The default is "", meaning VDSM can be scheduled by '
- ' the OS to run on any core. '
+ 'to run. The default is "1", meaning VDSM can be scheduled by '
+ ' the OS to run on the second core of the system. '
'Valid examples: "1", "0,1", "0,2,3"'),
('ssl_implementation', '@SSL_IMPLEMENTATION@',
--
To view, visit https://gerrit.ovirt.org/48296
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9a00926926bb4075e17b69f633bf31b5389eefc1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Yaniv Bronhaim has uploaded a new change for review.
Change subject: remove redundant tabs from vdsmd init script
......................................................................
remove redundant tabs from vdsmd init script
Change-Id: I8c09fb78b14bf2184c69f01bed34333d9fc43eed
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M init/vdsmd_init_common.sh.in
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/48233/1
diff --git a/init/vdsmd_init_common.sh.in b/init/vdsmd_init_common.sh.in
index 5f2671b..538c047 100644
--- a/init/vdsmd_init_common.sh.in
+++ b/init/vdsmd_init_common.sh.in
@@ -260,9 +260,9 @@
ret=$?
elif grep -q '^vdsm-4\.16\.' "${upgraded_ver_file}"; then
# REQUIRED_FOR upgrade from vdsm-4.16.z
- # Both mutlipath and sasl password were configured in 4.16 as
- # part of the installation - see vdsm-4.16 spec. Since 4.17 the
- # logic moved to vdsm-tool
+ # Both mutlipath and sasl password were configured in 4.16 as
+ # part of the installation - see vdsm-4.16 spec. Since 4.17 the
+ # logic moved to vdsm-tool
"$VDSM_TOOL" configure --module multipath --module passwd
ret=$?
fi
--
To view, visit https://gerrit.ovirt.org/48233
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c09fb78b14bf2184c69f01bed34333d9fc43eed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Francesco Romani has uploaded a new change for review.
Change subject: sampling: fix semaphore misusing
......................................................................
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it succesfully.
Otherwise, if a previous call was stuck, we violate the
contract of the semaphore.
Change-Id: I9b67cc4efe70b5d2ec8838ace6dfb16648528c46
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/32/48332/1
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 1026eaf..3eaf376 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -492,10 +492,10 @@
def __call__(self):
timestamp = self._stats_cache.clock()
+ acquired = self._sampling.acquire(blocking=False)
# we are deep in the hot path. bool(ExpiringCache)
# *is* costly so we should avoid it if we can.
- fast_path = (
- self._sampling.acquire(blocking=False) and not self._skip_doms)
+ fast_path = acquired and not self._skip_doms
try:
if fast_path:
# This is expected to be the common case.
@@ -516,7 +516,8 @@
else:
self._stats_cache.put(_translate(bulk_stats), timestamp)
finally:
- self._sampling.release()
+ if acquired:
+ self._sampling.release()
def _get_responsive_doms(self):
vms = self._get_vms()
--
To view, visit https://gerrit.ovirt.org/48332
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b67cc4efe70b5d2ec8838ace6dfb16648528c46
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Francesco Romani has posted comments on this change.
Change subject: host stats: Add cpusStatus to vdsStats
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/46270/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 2072: # the KSM feature (in bytes)
Line 2073: #
Line 2074: # @memCommitted: Amount of memory committed to running VMs (in MB)
Line 2075: #
Line 2076: # @cpusStatus: Boolean list indicating wich cpus are online
> List of booleans indicating which cpus are online (True) or offline (False)
+1
Line 2077: # (new in version 4.17.9)
Line 2078: #
Line 2079: # @swapTotal: The total amount of swap space (in MB)
Line 2080: #
--
To view, visit https://gerrit.ovirt.org/46270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73c92f563c7c3e8ffbbcf639eba27fbe55389994
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes