Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: fix semaphore misusing
......................................................................
sampling: fix semaphore misusing
We should release the internal _sampling semaphore only
if we acquired it succesfully.
Otherwise, if a previous call was stuck, we violate the
contract of the semaphore.
Change-Id: I9b67cc4efe70b5d2ec8838ace6dfb16648528c46
Bug-Url:
https://bugzilla.redhat.com/1250839
Backport-To: 3.6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
Reviewed-on:
https://gerrit.ovirt.org/48332
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Continuous-Integration: Dan Kenigsberg <danken(a)redhat.com>
---
M vdsm/virt/sampling.py
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Francesco Romani: Verified
--
To view, visit
https://gerrit.ovirt.org/48332
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b67cc4efe70b5d2ec8838ace6dfb16648528c46
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation(a)ovirt.org