Ryan Harper has uploaded a new change for review.
Change subject: storage: Move nfsSD.getFileUtils() to FileStorageDomain class
......................................................................
storage: Move nfsSD.getFileUtils() to FileStorageDomain class
If I create an iso-domain out of a LOCALFS storage type, when I
call getIsoList on the storage pool which includes the iso-domain
vdsm complains that LocalFS does not have getFileList method.
The nfsSD class has the exact method for finding files that is
needed. By moving the implementation to the base class for both
nfs and localfs types, they can share the implementation.
Change-Id: I31cf133464751ffcf222140e83fa8d0e32940c05
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M vdsm/storage/fileSD.py
M vdsm/storage/nfsSD.py
2 files changed, 35 insertions(+), 34 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/4478/1
--
To view, visit http://gerrit.ovirt.org/4478
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31cf133464751ffcf222140e83fa8d0e32940c05
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Mark Wu has uploaded a new change for review.
Change subject: Separate API binding from BindingXMLRPC
......................................................................
Separate API binding from BindingXMLRPC
Move the API binding functions to a separate file. And then it could be
reused by other modules which need interact with vdsm internal.
Change-Id: Ic668df9012af737aed3dd1024bd61b97a1765dd4
Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm.spec.in
A vdsm/Binding.py
M vdsm/BindingXMLRPC.py
M vdsm/Makefile.am
5 files changed, 567 insertions(+), 533 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/4424/1
--
To view, visit http://gerrit.ovirt.org/4424
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic668df9012af737aed3dd1024bd61b97a1765dd4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Ryan Harper has uploaded a new change for review.
Change subject: tests: fix gluster storage exception test
......................................................................
tests: fix gluster storage exception test
make check fails after gluster merge:
FAIL: test_collisions (main.TestGlusterExceptions)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/root/rpmbuild/BUILD/vdsm-4.9.6/tests/main.py", line 71, in
test_collisions
self.assertTrue(obj.code >= 5000)
AssertionError: False is not true
Looking at vdsm/gluster/exception.py line 29 of 350 we can
see that the gluster defined range for exceptions is
4100-4800. Update the test case to match reserved range.
Change-Id: I94a4ac90cff064def5eeac30cbdab664c88b5253
Signed-off-by: Ryan Harper <ryanh(a)us.ibm.com>
---
M tests/main.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/4822/1
--
To view, visit http://gerrit.ovirt.org/4822
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94a4ac90cff064def5eeac30cbdab664c88b5253
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh(a)us.ibm.com>
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: BZ#821867: Do not append comments to config values
......................................................................
BZ#821867: Do not append comments to config values
In Fedora 17, libvirt is reading the entire line configuration file,
ignoring comments.
Starting libvirt as:
root 907 0.0 0.3 459996 13556 ? Ssl 09:05 0:00
/usr/sbin/libvirtd --listen # by vdsm
This patch will add the vdsm comments above of configuration, example:
# listen_addr - by vdsm
listen_addr="0.0.0.0"
Change-Id: I01840754844fbcd4d3f44bd16e0627015a59af83
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M vdsm/vdsmd.init.in
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/4716/1
--
To view, visit http://gerrit.ovirt.org/4716
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I01840754844fbcd4d3f44bd16e0627015a59af83
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
On Fri, May 25, 2012 at 03:46:39AM -0400, Jenkins oVirt Server wrote:
>
> BUILD FAILURE
> Build URL: http://jenkins.ovirt.org/job/vdsm_unit_tests/163/
> Project: vdsm_unit_tests
> Date of build: Fri, 25 May 2012 03:40:29 -0400
> Build duration: 6 min 10 sec
>
> CHANGE SET
> Revision d707ce49718d7506b3107b8699240322e6a8058c by barumuga: (Added gluster cli support in supervdsm.)
>
> Name: main Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)
>
> Failed: main.TestGlusterExceptions.test_collisions
>
> Name: md_utils_tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
>
Timothy, have you tested this during verification? I know that I haven't
:-(
Either way, please have it fixed as soon as possible.
Regards,
Dan.