Hello ShaoHe Feng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/4794
to review the following change.
Change subject: change the code style of volume.py for PEP8 compliance
......................................................................
change the code style of volume.py for PEP8 compliance
Change-Id: Ife117977d98b409f32bea6ef466df3418c632ec7
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm/storage/volume.py
2 files changed, 133 insertions(+), 80 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/94/4794/1
--
To view, visit http://gerrit.ovirt.org/4794
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife117977d98b409f32bea6ef466df3418c632ec7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Hello Bing Bu Cao,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/4795
to review the following change.
Change subject: Fixing pep8 in vdsm/hooks.py
......................................................................
Fixing pep8 in vdsm/hooks.py
Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9
Signed-off-by: Cao,Bing Bu <mars(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm/hooks.py
2 files changed, 41 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/95/4795/1
--
To view, visit http://gerrit.ovirt.org/4795
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3aec8fff9e1dd48237e6896118d407fc9eb331b9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Bing Bu Cao <mars(a)linux.vnet.ibm.com>
Hello ShaoHe Feng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/4797
to review the following change.
Change subject: change the code style of SecureXMLRPCServer.py for PEP8 compliance
......................................................................
change the code style of SecureXMLRPCServer.py for PEP8 compliance
Change-Id: I28328713dc4be9fb78e8c1f48c9f93b36a4d9eb2
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm/SecureXMLRPCServer.py
2 files changed, 27 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/4797/1
--
To view, visit http://gerrit.ovirt.org/4797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28328713dc4be9fb78e8c1f48c9f93b36a4d9eb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Hello ShaoHe Feng,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/4798
to review the following change.
Change subject: change the code style of before_vm_start.py for PEP8 compliance
......................................................................
change the code style of before_vm_start.py for PEP8 compliance
Change-Id: Ic0e86c35be128f542151557d12d30a095fa4624f
Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
---
M Makefile.am
M vdsm_hooks/fileinject/before_vm_start.py
2 files changed, 40 insertions(+), 18 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/4798/1
--
To view, visit http://gerrit.ovirt.org/4798
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0e86c35be128f542151557d12d30a095fa4624f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shu Ming <shuming(a)linux.vnet.ibm.com>
Gerrit-Reviewer: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com>
Adam Litke has uploaded a new change for review.
Change subject: API: Add formal definition for disk types
......................................................................
API: Add formal definition for disk types
Expose the enum representing disk types in the public API. Along the way,
correct some docstrings that suggest the diskType parameter is a string when it
is an integer.
Signed-off-by: Adam Litke <agl(a)us.ibm.com>
Change-Id: I797bc9dd2b86678c14ba4c5abdc4a87f618b6b09
---
M vdsm/API.py
M vdsm/storage/fileVolume.py
M vdsm/storage/sp.py
3 files changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/4957/1
--
To view, visit http://gerrit.ovirt.org/4957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I797bc9dd2b86678c14ba4c5abdc4a87f618b6b09
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Lei Li has uploaded a new change for review.
Change subject: Add passwd command to vdsm-tool
......................................................................
Add passwd command to vdsm-tool
Move and encapsulate the update-saslpasswd2 from
post section to vdsm-tool function.
Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Signed-off-by: Lei Li <lilei(a)linux.vnet.ibm.com>
---
M vdsm-tool/Makefile.am
A vdsm-tool/passwd.py
M vdsm.spec.in
3 files changed, 48 insertions(+), 7 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/4528/1
--
To view, visit http://gerrit.ovirt.org/4528
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I76b5aee4c2f11a7680c675c171ff35a463a70402
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lei Li <lilei(a)linux.vnet.ibm.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: BZ#788640 - Avoid race between several concurrently running merges.
......................................................................
BZ#788640 - Avoid race between several concurrently running merges.
Merge snapshots shouldn't run on template's images.
Looking for volumes children in merged image only instead of a whole domain.
Change-Id: I9c04b343781c98a852f7de794a32c7db8e863847
---
M vdsm/storage/blockVolume.py
M vdsm/storage/fileVolume.py
M vdsm/storage/image.py
3 files changed, 36 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/2757/1
--
To view, visit http://gerrit.ovirt.org/2757
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9c04b343781c98a852f7de794a32c7db8e863847
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Igor Lvovsky has uploaded a new change for review.
Change subject: Do not validate image during the move operation
......................................................................
Do not validate image during the move operation
Change-Id: I8c470719c58eef34cf972e379d96b80e379066aa
---
M vdsm/storage/hsm.py
M vdsm/storage/image.py
M vdsm/storage/sp.py
3 files changed, 0 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/2756/1
--
To view, visit http://gerrit.ovirt.org/2756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c470719c58eef34cf972e379d96b80e379066aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>