From Dan Kenigsberg danken@redhat.com:
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Create libvirt network only when needed
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/74390/7/lib/vdsm/network/libvirt.py
File lib/vdsm/network/libvirt.py:
PS7, Line 97: NetworksUsersCache
not a fan of class-as-namespace approach (also known as staticmethod fest)
I kinda like it...
--
To view, visit
https://gerrit.ovirt.org/74390
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie55b08e9bdffcd8ea663b647c6d6dcf3363b9847
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Dan Kenigsberg
danken@redhat.com
Gerrit-Reviewer: Edward Haas
edwardh@redhat.com
Gerrit-Reviewer: Francesco Romani
fromani@redhat.com
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
mpolednik@redhat.com
Gerrit-Reviewer: Petr Horáček
phoracek@redhat.com
Gerrit-Reviewer: gerrit-hooks
automation@ovirt.org
Gerrit-HasComments: Yes