From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: wip:dpdk: add dpdkvhostuser port
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/74327/5/lib/vdsm/virt/vmdevices/network.py
File lib/vdsm/virt/vmdevices/network.py:
Line 146: if self.vlanId is not None:
Line 147: vlan = iface.appendChildWithArgs('vlan')
Line 148: vlan.appendChildWithArgs('tag', id=str(self.vlanId))
Line 149:
Line 150: elif self.device == 'vhostuser':
I think that this should depend on an explicit request from Engine, e.g.
if tobool(self.conf['custom']['vhostuser']):
Line 151: ovs_bridge = supervdsm.getProxy().ovs_bridge(self.network)
Line 152: self._source_ovsdpdk_bridge(iface, ovs_bridge['name'])
Line 153:
Line 154: else:
--
To view, visit
https://gerrit.ovirt.org/74327
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81cf52f17ffe01713dd6502d68c4b17c64e5335
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes