From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dumpStorageTable: remove module and all references
......................................................................
dumpStorageTable: remove module and all references
dumpStorageTable has been used only by sos report. patch
https://gerrit.ovirt.org/#/c/62628/ replaced it with
dump_volume_chains since dumpStorageTable was using vdscli and
not jsonrpc. Since sos report was its only use, there is no point
keeping it.
dumpStorageTable was removed and all references to it were deleted.
Change-Id: I7d71e08315688537d1c200e7e60d7e0df6d5512c
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M .gitignore
M vdsm.spec.in
M vdsm/Makefile.am
D vdsm/dumpStorageTable.py.in
4 files changed, 0 insertions(+), 331 deletions(-)
Approvals:
Yaniv Bronhaim: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d71e08315688537d1c200e7e60d7e0df6d5512c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mkalinin(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: client: construct namespaces from schema
......................................................................
Patch Set 3:
the code we change here didn't expose anything related to gluster. how is this relevant now? this replaces the current hard-coded behavior which is totally right. we should handle load of addition schema files separately.. not related to this change imo
--
To view, visit https://gerrit.ovirt.org/67373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib550a86e7f66d3fd7e58fbe2d8b2f381cf155e79
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Remove invalid pyc file tests
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/67339/1//COMMIT_MSG
Commit Message:
Line 7: tests: Remove invalid pyc file tests
Line 8:
Line 9: moduleloader test was creating empty (invalid) "a.pyc" file. Existance
Line 10: of an invalid "a.pyc" file may casue the test to fail if "a.pyc" file is
Line 11: newer then the "a.py". This depends on the resolution of the file system
> But I did not see the code fail with this, what I see is always failures to
is it new failure? this test was like that for quite long. maybe its related to your new import check that you introduced.. if so please mention the regression in the commit message
Line 12: timestamps and the timing.
Line 13:
Line 14: Since import of pyc files is not the subject of this test, I removed the
Line 15: pyc file from the test data.
--
To view, visit https://gerrit.ovirt.org/67339
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd6371a5f4ace637ea99d4a91550a277cbf3f72
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Use assertIn for better error message
......................................................................
tests: Use assertIn for better error message
If the pid was not found the failure will include now the contents of
the list, hopefully making it easier to debug.
Change-Id: I9737f79fb505647f0d11ff12e3da74d2e61cd6b4
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/utils_test.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67385
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9737f79fb505647f0d11ff12e3da74d2e61cd6b4
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: Fix flaky test on travis
......................................................................
tests: Fix flaky test on travis
TestPgrep is failing from time to time on traivs, but not on jenkins.
Looking at the test, it seems that starting 3 child processes and
pgreping for them immediately is racy, since we don't have a guarantee
that a child process is running when execCmd returns.
Attempt to fix by adding fragile timeout, this should be good enough for
this test.
Change-Id: I9fd87425ce2f2c0055c7e79e0aace3411afca568
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M tests/utils_test.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/67384
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd87425ce2f2c0055c7e79e0aace3411afca568
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>