From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virtio-scsi: add support for IO threads
......................................................................
virtio-scsi: add support for IO threads
virtio-scsi supports per-controller IO threads instead of per-disk.
We therefore have to manually extend virtio-scsi controller (or our
Controller device in other words) to handle engine's communication
regarding IO threads [1].
[1] https://gerrit.ovirt.org/#/c/64948/
Change-Id: I1ddbbae22f27cc9064803fcb59df3db49d0202aa
Signed-off-by: Martin Polednik <mpolednik(a)redhat.com>
---
M tests/deviceTests.py
M vdsm/virt/vmdevices/core.py
2 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Martin Polednik: Verified
--
To view, visit https://gerrit.ovirt.org/67459
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ddbbae22f27cc9064803fcb59df3db49d0202aa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: Add tests for poll and wait failures
......................................................................
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/65294/11/tests/utils_test.py
File tests/utils_test.py:
Line 92:
Line 93: def tearDown(self):
Line 94: if self.proc_poll() is None:
Line 95: self.proc_kill()
Line 96: self.proc_wait()
I'd love to change this mocking to be with python mock
Line 97:
Line 98: def test_process_running(self):
Line 99: with utils.terminating(self.proc):
Line 100: self.assertIsNone(self.proc_poll())
Line 154: self.assertEqual(type(e.exception.error), ExpectedFailure)
Line 155:
Line 156: # Note: We cannot check return code since AsyncProc.returncode is a
Line 157: # property calling poll(). The return code here may be None or -9,
Line 158: # depeending on timing.
double e
Line 159:
Line 160:
Line 161: class ExpectedFailure(Exception):
Line 162: pass
--
To view, visit https://gerrit.ovirt.org/65294
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8674c9c3c2118041c74213cd8ce0d383086d6cbf
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move threadPool module to vdsm storage lib
......................................................................
Patch Set 5:
passes QE tier1
--
To view, visit https://gerrit.ovirt.org/56571
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5f4edd8eea38fdb6bdf3be5c7732fee0b56d58e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No