Nir Soffer has uploaded a new change for review.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl
......................................................................
gitignore: Ingore vdsm-lvm.rule.tpl
In a previous commit I forgot to add this new template to the ignore
list, which breaks the build. I will be punished for this.
Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/30/33630/1
diff --git a/.gitignore b/.gitignore
index 5890806..bcd5915 100644
--- a/.gitignore
+++ b/.gitignore
@@ -61,6 +61,7 @@
vdsm/storage/protect/safelease
vdsm/storage/lvm.env
vdsm/storage/vdsm-lvm.rules
+vdsm/storage/vdsm-lvm.rules.tpl
vdsm/sudoers.vdsm
vdsm/svdsm.logger.conf
vdsm/vdscli.py
--
To view, visit http://gerrit.ovirt.org/33630
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/33611/2/tests/sslTests.py
File tests/sslTests.py:
Line 109:
Line 110: class SocketTests(TestCaseBase):
Line 111:
Line 112: def test_block_socket(self):
Line 113: # this test make sure that we won't block during
I don't understand how this test works :-(
You start a server, open a TCP connection to it, but you don't check that the server is still responsive.
Would this test really fail on master branch (before your fix)?
I think that you should:
* start a server
* open a DoS connection to it
* open a legitimate client to the server
* if the client is not served within 10 seconds, fail the test.
Line 114: # accept. It will hang the build if accept blocks
Line 115: server = TestServer()
Line 116: server.start()
Line 117: try:
Line 119: sock.settimeout(1)
Line 120: sock.connect((HOST, server.port))
Line 121: finally:
Line 122: server.stop()
Line 123: sock.close()
puritan: at this point, "sock" may have not been defined. better use
with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock:
Line 124:
Line 125:
Line 126: class VerifyingTransportTests(TestCaseBase):
Line 127:
--
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Martin Peřina has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
......................................................................
Patch Set 1: Verified+1
Verified, that it fixes engine - host connection issues after host was fenced when using JSONRPC (more than 10 tests executed without error).
Verified, that it doesn't introduce any error in the above scenario when using XMLRPC (6 tests executed without errror)
--
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
Francesco Romani has uploaded a new change for review.
Change subject: virt: sampling: more cautious disk stats check
......................................................................
virt: sampling: more cautious disk stats check
In commit d6d0eb763e623 we changed the disk stats
collection to deal with the benign case of
known-missing disk stats samples, to avoid add
bogus error on the logs.
Unfortunately a case was missing in the live
storage migration flow, which causes
TypeError: argument of type 'NoneType' is not iterable
in the logs defeating the purposes of the
originating change.
This patch fixes this issue by adding the missing
check.
Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/33482/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ad8cb0e..0f8845e 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -539,7 +539,7 @@
dStats['imageID'] = vmDrive.imageID
elif "GUID" in vmDrive:
dStats['lunGUID'] = vmDrive.GUID
- if sInfo is not None and (
+ if sInfo is not None and eInfo is not None and (
vmDrive.name in sInfo and vmDrive.name in eInfo):
# will be None if sampled during recovery
dStats.update(self._calcDiskRate(vmDrive, sInfo, eInfo,
@@ -594,7 +594,8 @@
'writeLatency': '0',
'flushLatency': '0'}
- if sInfo is not None and (dName in sInfo and dName in eInfo):
+ if sInfo is not None and eInfo is not None and (
+ dName in sInfo and dName in eInfo):
# will be None if sampled during recovery
# in case of hotplugged disk, start samples will
# be missed until the sampling code catches up.
--
To view, visit http://gerrit.ovirt.org/33482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I059b69c33d45950f8377597ee8c6e7824e1ec223
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Francesco Romani has uploaded a new change for review.
Change subject: virt: dump domain xml when change is detected
......................................................................
virt: dump domain xml when change is detected
The Domain XML should not change often during the lifetime of a VM.
Nevertheless, it is greatly helpful to have up-to-date information
when troubleshooting issues.
This patch logs the domain XML whenever a change is detected, to improve
the debuggability of VDSM.
Change-Id: I658ed887e258c4217a3d1eddb4924688b5a613f6
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/33549/1
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index ad8cb0e..e728902 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -4492,8 +4492,11 @@
self._lastXMLDesc = self._dom.XMLDesc(0)
devxml = _domParseStr(self._lastXMLDesc).childNodes[0]. \
getElementsByTagName('devices')[0]
- self._devXmlHash = hash(devxml.toxml())
-
+ xmlHash = hash(devxml.toxml())
+ if xmlHash != self._devXmlHash:
+ self.log.debug('changed device configuration:\n%s',
+ self._lastXMLDesc)
+ self._devXmlHash = xmlHash
return self._lastXMLDesc
def _ejectFloppy(self):
--
To view, visit http://gerrit.ovirt.org/33549
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I658ed887e258c4217a3d1eddb4924688b5a613f6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/33611/1//COMMIT_MSG
Commit Message:
Line 9: When rebooting host most of the times ssl_accept blocks when there is
Line 10: new connection estabilished just after socket is opened. Setting timeout
Line 11: on socket seems to help but when testing I noticed sometimes there is
Line 12: still connection blocked on ssl_accept.
Line 13:
And more importantly, without this timeout, it is SO easy to DoS us.
Please add a test that verifies that opening a plaintext TCP connection to an SSL server does not block us, and backport as far as you can.
Line 14:
Line 15: Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
--
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33529
to review the following change.
Change subject: networkTests: BOND_NAME constant changed to bond11
......................................................................
networkTests: BOND_NAME constant changed to bond11
getVdsCaps on rhel6 reports bond0-4 as existing
regardless of their true existence (see
_report_legacy_bondings).
This confuses the testing changes in upcoming
patches, hence we prefer to test a bond name with
no legacy burdens.
Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/31332
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
Tested-by: Dan Kenigsberg <danken(a)redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/29/33529/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 141b47b..cbc6d0a 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -46,7 +46,7 @@
NETWORK_NAME = 'test-network'
VLAN_ID = '27'
-BONDING_NAME = 'bond0'
+BONDING_NAME = 'bond11'
IP_ADDRESS = '240.0.0.1'
IP_NETWORK = '240.0.0.0'
IP_ADDRESS_IN_NETWORK = '240.0.0.50'
--
To view, visit http://gerrit.ovirt.org/33529
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9f1892eaeae68583a792cb122cad4a5162e68fa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>