Daniel Erez has posted comments on this change.
Change subject: jsonrpc: mssing clone image structure in command info
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/33669/1/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 408: 'Host_getVMList': {'call': Host_getVMList_Call, 'ret': Host_getVMList_Ret},
Line 409: 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret': 'vmList'},
Line 410: 'Host_getAllVmStats': {'ret': 'statsList'},
Line 411: 'Host_setupNetworks': {'ret': 'status'},
Line 412: 'Image_cloneStructure': {'ret': 'uuid'},
same should be done for 'syncImageData'
Line 413: 'Image_delete': {'ret': 'uuid'},
Line 414: 'Image_deleteVolumes': {'ret': 'uuid'},
Line 415: 'Image_getVolumes': {'ret': 'uuidlist'},
Line 416: 'Image_download': {'ret': 'uuid'},
--
To view, visit http://gerrit.ovirt.org/33669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/33634
to review the following change.
Change subject: gitignore: Ingore vdsm-lvm.rule.tpl
......................................................................
gitignore: Ingore vdsm-lvm.rule.tpl
In a previous commit I forgot to add this new template to the ignore
list, which breaks the build. I will be punished for this.
Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33630
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/33634/1
diff --git a/.gitignore b/.gitignore
index efb99aa..d1e919b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -58,6 +58,7 @@
vdsm/storage/protect/safelease
vdsm/storage/lvm.env
vdsm/storage/vdsm-lvm.rules
+vdsm/storage/vdsm-lvm.rules.tpl
vdsm/sudoers.vdsm
vdsm/svdsm.logger.conf
vdsm/vdscli.py
--
To view, visit http://gerrit.ovirt.org/33634
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibc30423f6f47a6d8eb0326d94f6ce69ce3cdd5f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: ssl: ssl_accept blocks after reboot
......................................................................
ssl: ssl_accept blocks after reboot
When rebooting host most of the times ssl_accept blocks when there is
new connection established just after socket is opened. Setting timeout
on socket seems to help but when testing I noticed sometimes there is
still connection blocked on ssl_accept.
Bug-Url: https://bugzilla.redhat.com/1147487
Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Signed-off-by: pkliczewski <piotr.kliczewski(a)gmail.com>
Signed-off-by: Saggi Mizrahi <smizrahi(a)redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33643
Reviewed-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M lib/vdsm/sslutils.py
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Yaniv Bronhaim: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/33643
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: mssing clone image structure in command info
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/33669
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3235c1f09ff08948c2951d09a8041aca0a1575ed
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No