Hi all,
We currently have two pending updates: wlroots 0.6.0: https://bugzilla.redhat.com/show_bug.cgi?id=1706341 sway 1.1.1: https://bugzilla.redhat.com/show_bug.cgi?id=1706339
There is a PR for wlroots: https://src.fedoraproject.org/rpms/wlroots/pull-request/2
What's the status there? I currently don't have enough insight into wlroots to just merge this, can someone review the PR? I would then continue pushing the update for sway.
Thanks! Till
Hi, TL;DR: the PR should be mostly OK (assuming it builds as is) and we can proceed with it if we are in hurry. See below for notes.
Long verstion: the PR is mostly correct, apart from the mess with glesv2 (see discussion on the PR), which should be (temporarily) resolved by now in the mesa package. The only thing I would like to see before merging is going back to using `BR: pkgconfig(glesv2)` in place of `BR: mesa-libGLES-devel`, but the update should be fine even as is.
I tried to do a quick fix up and push it to the PR, but instead ended creating two new branches (upgrade/0.6.0 and pr/2) that I'm not allowed to delete :-/ – sorry about that. Anyone know the proper way of collaboration on Pagure PR?
That being said, the spec file is more complicated than it should be – comments listing results of dependency resolution, pre-release git-checkout macro magic, etc. Once the upgrade in on it's merry way, I will probably prepare a cleanup PR.
Best regards,
On 6/7/19 12:04 PM, Jan Staněk wrote:
Hi, TL;DR: the PR should be mostly OK (assuming it builds as is) and we can proceed with it if we are in hurry. See below for notes.
Long verstion: the PR is mostly correct, apart from the mess with glesv2 (see discussion on the PR), which should be (temporarily) resolved by now in the mesa package. The only thing I would like to see before merging is going back to using `BR: pkgconfig(glesv2)` in place of `BR: mesa-libGLES-devel`, but the update should be fine even as is.
I tried to do a quick fix up and push it to the PR, but instead ended creating two new branches (upgrade/0.6.0 and pr/2) that I'm not allowed to delete :-/ – sorry about that. Anyone know the proper way of collaboration on Pagure PR?
I think if you want to collaborate on a single PR, you need to create the PR from a repository/branch that all people can write to.
That being said, the spec file is more complicated than it should be – comments listing results of dependency resolution, pre-release git-checkout macro magic, etc. Once the upgrade in on it's merry way, I will probably prepare a cleanup PR.
Yes that sounds like the best way forward: First get 0.6.0 done and then clean up in a separate PR.
Kind regards Till
I have also noticed that swaybg was split from sway in 1.1. It is still required by sway, but it should be packaged separately.
The package review is ready: https://bugzilla.redhat.com/show_bug.cgi?id=1718928; anyone up for it?
Best regards,
On 6/10/19 4:50 PM, Jan Staněk wrote:
I have also noticed that swaybg was split from sway in 1.1. It is still required by sway, but it should be packaged separately.
The package review is ready: https://bugzilla.redhat.com/show_bug.cgi?id=1718928; anyone up for it?
I'll take it.
Kind regards, Till