client/tools/rhnpush/archive.py | 1 +
client/tools/rhnpush/rhnpush.spec | 5 ++++-
client/tools/rhnpush/rhnpush_config.py | 9 +++++++++
client/tools/rhnpush/solaris2mpm.py | 10 +++++-----
rel-eng/packages/rhnpush | 2 +-
5 files changed, 20 insertions(+), 7 deletions(-)
New commits:
commit 2742f51ba7ab70da68ffd07eab9f98b3625481de
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Thu Feb 28 09:34:04 2013 +0100
Automatic commit of package [rhnpush] release [5.5.60-1].
diff --git a/client/tools/rhnpush/rhnpush.spec b/client/tools/rhnpush/rhnpush.spec
index adb1616..9a5f3d5 100644
--- a/client/tools/rhnpush/rhnpush.spec
+++ b/client/tools/rhnpush/rhnpush.spec
@@ -4,7 +4,7 @@ Name: rhnpush
Group: Applications/System
License: GPLv2
URL:
http://fedorahosted.org/spacewalk
-Version: 5.5.59
+Version: 5.5.60
Release: 1%{?dist}
Source0:
https://fedorahosted.org/releases/s/p/spacewalk/%{name}-%{version}.tar.gz
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
@@ -75,6 +75,9 @@ spacewalk-pylint $RPM_BUILD_ROOT%{rhnroot}
%doc COPYING
%changelog
+* Thu Feb 28 2013 Michael Mraka <michael.mraka(a)redhat.com> 5.5.60-1
+- fixed pylint warnings
+
* Fri Jan 18 2013 Michael Mraka <michael.mraka(a)redhat.com> 5.5.59-1
- silence pylint warning
diff --git a/rel-eng/packages/rhnpush b/rel-eng/packages/rhnpush
index 6d162c9..6280f20 100644
--- a/rel-eng/packages/rhnpush
+++ b/rel-eng/packages/rhnpush
@@ -1 +1 @@
-5.5.59-1 client/tools/rhnpush/
+5.5.60-1 client/tools/rhnpush/
commit e1f5b4d232fa9db7467afeb726f908c4d1348a8e
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Thu Feb 28 09:29:58 2013 +0100
silence pylint warnings
R0924: 28,0:rhnpushConfigParser: Badly implemented Container, implements __getitem__
but not __delitem__, __len__, __setitem__
diff --git a/client/tools/rhnpush/rhnpush_config.py
b/client/tools/rhnpush/rhnpush_config.py
index b8dd543..d4250b8 100644
--- a/client/tools/rhnpush/rhnpush_config.py
+++ b/client/tools/rhnpush/rhnpush_config.py
@@ -119,6 +119,15 @@ class rhnpushConfigParser:
def __getitem__(self, item):
return self.get_option(item)
+ def __delitem__(self, item):
+ pass
+
+ def __len__(self, item):
+ pass
+
+ def __setitem__(self, item):
+ pass
+
#Takes all of the configuration options read in by the ConfigParser and makes them
attributes of the object.
def _add_config_as_attr(self, ensure_consistency=False):
for k in self._keys():
commit abcbb10e30ce60318f4a7dd150078ffbd475f58f
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Fri Jan 25 11:47:24 2013 +0100
disable false positive warnings
fixing
E1101:175,4:rhn_popen: Instance of 'Popen' has no 'stdin' member
E1101:182,20:rhn_popen: Instance of 'Popen' has no 'stdout' member
E1101:182,43:rhn_popen: Instance of 'Popen' has no 'stderr' member
E1101:188,17:rhn_popen: Instance of 'Popen' has no 'poll' member
diff --git a/client/tools/rhnpush/archive.py b/client/tools/rhnpush/archive.py
index f5f0f09..65c7bd3 100644
--- a/client/tools/rhnpush/archive.py
+++ b/client/tools/rhnpush/archive.py
@@ -324,6 +324,7 @@ def _has_executable(exc):
def _my_popen(cmd):
"""Execute a command as a subprocess and return its exit
status"""
+ # pylint: disable=E1101
popen = subprocess.Popen(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, close_fds=True, shell=True)
popen.stdin.close()
commit 82b744a816c377eaf9f7e2674b38bdea149a3cba
Author: Michael Mraka <michael.mraka(a)redhat.com>
Date: Thu Feb 28 09:22:59 2013 +0100
fixed pylint warnings
W1401: 39,0: Anomalous backslash in string: '\('. String constant might be
missing an r prefix.
W1401: 39,0: Anomalous backslash in string: '\)'. String constant might be
missing an r prefix.
W1401: 40,0: Anomalous backslash in string: '\S'. String constant might be
missing an r prefix.
W1401: 40,0: Anomalous backslash in string: '\s'. String constant might be
missing an r prefix.
W1401: 41,0: Anomalous backslash in string: '\S'. String constant might be
missing an r prefix.
...
diff --git a/client/tools/rhnpush/solaris2mpm.py b/client/tools/rhnpush/solaris2mpm.py
index 114d65b..6072bcc 100644
--- a/client/tools/rhnpush/solaris2mpm.py
+++ b/client/tools/rhnpush/solaris2mpm.py
@@ -35,11 +35,11 @@ _temp_files = []
# package dependency parsing regular expressions -------------------------
-_dep_regex = re.compile("(?P<code>[PIR]) +(?P<name>[^ \t]+)")
-_arch_ver_regex = re.compile("^ *(?:\((?P<arch>[a-zA-Z0-9]+)\))?"
- " *(?P<ver>[^,]+)(,[
\t\S]*REV=(?P<rev>[^,\s]+))?")
-_ver_regex = re.compile("(?P<ver>[^,]+)(,[
\t\S]*REV=(?P<rev>[^,\s]+))?")
-_illegal_ver_regex =
re.compile("[/\\\?\*:\|\"'<>\~\$\(\)[\]{}&=\s,]")
+_dep_regex = re.compile(r"(?P<code>[PIR]) +(?P<name>[^ \t]+)")
+_arch_ver_regex = re.compile(r"^ *(?:\((?P<arch>[a-zA-Z0-9]+)\))?"
+ r" *(?P<ver>[^,]+)(,[
\t\S]*REV=(?P<rev>[^,\s]+))?")
+_ver_regex = re.compile(r"(?P<ver>[^,]+)(,[
\t\S]*REV=(?P<rev>[^,\s]+))?")
+_illegal_ver_regex =
re.compile(r"[/\\\?\*:\|\"'<>\~\$\(\)[\]{}&=\s,]")
# common solaris abreviations for the months -----------------------------