Thank you for the review, Shawn.
----- Original Message -----
From: "Shawn Wells" <shawn(a)redhat.com>
To: scap-security-guide(a)lists.fedorahosted.org
Sent: Friday, March 21, 2014 11:45:23 PM
Subject: Re: [PATCH] [Fedora] Switch on OVAL variables evaluation in rules description
On 3/21/14, 10:31 AM, Jan Lieskovsky wrote:
Based on xccdf:sub elements thread:
https://lists.fedorahosted.org/pipermail/scap-security-guide/2014-March/0...
switch on OVAL variables evaluation for Fedora content in XCCDF rules
description.
Together with that change, indent content of <pre> elements with one heading
tab character.
Tested on Fedora (both make & make validate seems to be working properly).
Please review.
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
When we originally started authoring content, some 2 years ago, the XCCDF
variable inclusion was not working (hence the comments scattered around).
Applied your patch locally - everything looks great! Note a few whitespace
errors, however this could be how I downloaded:
$ git apply /tmp/j1.patch
/tmp/j1.patch:104: trailing whitespace.
<tt>ClientAliveCountMax</tt> is set, edit the
<tt>/etc/ssh/sshd_config</tt>
warning: 1 line adds whitespace errors.
You are truly right, there was one whitespace noise case (didn't actually
try to apply the patch. Sorry for that -- second version shouldn't have it already).
Unclear on the purpose of the tabs though. For example:
-<pre>PASS_MIN_DAYS <i>DAYS</i></pre>
-A value of 1 day is considered to be sufficient for many environments.
+edit the file <tt>/etc/login.defs</tt>, locate the following line:
+<pre> PASS_MIN_DAYS <b>DAYS</b></pre>
+and correct it to have the form of:
+<pre> PASS_MIN_DAYS <b><sub
idref="var_accounts_minimum_age_login_defs"
/></b></pre>
+A value greater than 1 day is considered to be sufficient for many
environments.
In this case it gives the user the impression these values should be prefaced
with a tab. While technically acceptable, in /etc/login.defs everything is
defined starting as the first character. Is there a reason for the tab?
The intention was to prefix the particular row in HTML form of the guide with
a tab character to separate HTML text from command line syntax (IOW so the
command-line input would be differentiated not just by <pre> element, but also
intended from left by one tab).
But agree with you this might bring more confusion than the desired effect actually
(didn't look at this the way you did) thus removed the tabs from the attached second
version.
Please review [*].
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
[*] make / make validate & basic testing passed.
--
Shawn Wells
Director, Innovation Programs shawn(a)redhat.com | 443.534.0130
@shawndwells