----- Original Message -----
From: "Jan Lieskovsky" <jlieskov(a)redhat.com>
To: "SCAP Security Guide" <scap-security-guide(a)lists.fedorahosted.org>
Sent: Friday, July 25, 2014 3:12:56 PM
Subject: [PATCH] [RHEL/6] Include SCAP Security Guide logo into generated HTML guide (if
underlying openscap version
supports <svg> XHTML element to be present within <front-matter> element)
Hello folks,
the attached change adds support for displaying of SCAP Security Guide
(horizontal) logo in the HTML form of the guide (within it's <front-matter>
element).
Since the <svg> inclusion requires openscap of version v1.0.9 (at least) to
be able to handle SVG images within benchmark's description / front-matter /
rear-matter elements properly, the display of the logo has been made
conditional:
* the version of openscap package on the system is < 1.0.9, there will be
no change wrt to current <front-matter> content,
* the version of openscap package on the system is >= 1.0.9 (currently on
Fedora only), the SCAP Security Guide logo will be displayed (for now
just as plain image, without a href to Fedorahosted instance - this is
another
feature that needs to be implemented in openscap first).
You can see the new output after applying the patch & building the RPM on
Fedora (with openscap = 1.0.9). On RHEL-6 there won't be any difference (for
now).
Testing report:
Tested the change on all of RHEL-6, RHEL-7 & Fedora-20, and seems to be
working
properly (no change on RHEL-6, RHEL-7 & equipped with logo on Fedora).
To compare the output (current vs proposed one) check the attachments in the
Bugzilla bug:
[1]
https://bugzilla.redhat.com/show_bug.cgi?id=1123383#c1 (current state)
[2]
https://bugzilla.redhat.com/show_bug.cgi?id=1123383#c2 (state once this change is
applied)
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
Similar changes for RHEL-7 & Fedora transforms will follow shortly.
Please review.
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
--
SCAP Security Guide mailing list
scap-security-guide(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide
https://github.com/OpenSCAP/scap-security-guide/