----- Original Message -----
From: "Shawn Wells" <shawn(a)redhat.com>
To: scap-security-guide(a)lists.fedorahosted.org
Sent: Saturday, June 7, 2014 6:50:03 AM
Subject: Re: [PATCH] [*/utils/verify-references.py] Return non-zero status (to indicate
failure) if some warning
message was printed (some of the internal checks didn't pass)
On 6/6/14, 8:20 AM, Jan Lieskovsky wrote:
Currently */utils/verify-references.py script(s) (thus make validate for that
product) always return zero (success) status regardless if some of the
underlying
internal checks failed or not.
This is not good for subsequent automated processing e.g. via shell scripts.
Therefore if some of the verify-references.py check caused a warning to be
printed, return non-zero / 1 exit status to indicate failure (not to actually
need to parse the warning).
This is just cosmetic change which doesn't have impact if the RPM package
will be
built successfully or not (make validate isn't part of the RPM package
build),
but will simplify the testing / life for those actually running 'make
validate'
after each commit for that product.
Please review.
Thank you && Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
0001-utils-verify-references.py-Return-non-zero-status-to.patch
From 53fd3f4be3ca47a1d16f1d1ae9b68cd2d98c9dee Mon Sep 17 00:00:00 2001
From: Jan Lieskovsky <jlieskov(a)redhat.com> Date: Fri, 6 Jun 2014 17:09:17
+0200
Subject: [PATCH] [*/utils/verify-references.py] Return non-zero status (to
indicate failure) if some warning message was printed (some of the checks
didn't pass)
Signed-off-by: Jan Lieskovsky <jlieskov(a)redhat.com> ---
Fedora/utils/verify-references.py | 17 ++++++++++++++++-
OpenStack/utils/verify-references.py | 17 ++++++++++++++++-
RHEL/6/utils/verify-references.py | 17 ++++++++++++++++-
RHEL/7/utils/verify-references.py | 17 ++++++++++++++++-
RHEVM3/utils/verify-references.py | 17 ++++++++++++++++-
5 files changed, 80 insertions(+), 5 deletions(-)
..
ack
Thank you, pushed to master.
Regards, Jan.
--
Jan iankko Lieskovsky / Red Hat Security Technologies Team
_______________________________________________
scap-security-guide mailing list
scap-security-guide(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/scap-security-guide